fix(server): stop OpenCode V2 descendant sessions - #9904
Open
saphid wants to merge 390 commits into
Open
Conversation
github-actions
Bot
added
vouch:trusted
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR materially changes production OpenCode lifecycle behavior by recursively aborting descendant sessions during interrupts and external-scope release, including new timeout and error-propagation semantics. An unresolved comment also identifies potential unbounded upstream error data in diagnostics, so the change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
2 times, most recently
from
September 5, 2026 04:56
b82facd to
2ac9bfe
Compare
saphid
force-pushed
the
fix/v2-opencode-stop-release-20260905
branch
from
September 5, 2026 05:09
2232091 to
ed4c193
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed4c193. Configure here.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
2 times, most recently
from
September 8, 2026 03:31
9242b91 to
3d81172
Compare
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
- Re-route steering that races completion into idempotent follow-up dispatches - Preserve scheduled-task attribution and provider ownership history across clients
Port main's pull-request discovery, active thread ordering, async question dismissal, settlement fixes, provider-session import, attachment context, and provider correctness changes into orchestration v2. Keep the branch's intentional composer and subagent behavior while adopting main's web and mobile fixes. Prevent headless setup terminals from hanging on the color probe, and move the v2 migration block to 050-061 after main claimed 048-049.
Restore the failed-before-start timer guard, align two server fixtures with the reconciled behavior, and remove dead files, exports, and dependencies surfaced by Knip. Drop the temporary branch push trigger now that the PR is mergeable, so each update runs the pull-request workflow once.
Keep main's batch machine-update banner and update action while preserving the v2 runtime-based environment lock used by draft load balancing.
Adopt TypeScript 7 and Effect rc.112 across orchestration v2, including the TaggedError API migration and updated Effect-aware tests. Restore main's composer-aware scroll-to-end clearance while retaining selected-model settings sync, preview recording transfer, image galleries, desktop context menus, and layout hit targets. Regenerate the lockfile on the upgraded dependency baseline.
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
from
September 8, 2026 06:23
efd9994 to
6102d00
Compare
Advertise bounded socket snapshots and authoritative dispatch validation, omit raw command output and inline file bodies at the wire boundary, and preserve compact status metadata across web and mobile. Add transport-budget coverage for snapshots, resume, commands, legacy import, and projection maintenance.
saphid
force-pushed
the
fix/v2-opencode-stop-release-20260905
branch
from
September 9, 2026 00:29
25d0f5f to
cd77b23
Compare
This comment has been minimized.
This comment has been minimized.
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
from
September 9, 2026 06:39
8187b17 to
ada72ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode child sessions can outlive a root Stop or a released external adapter. Walk and abort known descendants, bound requests with cancellation, attempt siblings after a failure, and surface structured cleanup errors. Missing sessions count as already stopped. External adapter release also cleans up its owned sessions.
Rebuilt on V2
7dd9873ed, including test-only prerequisite #10865 (merge first). Current head5278d0f7d; the topic is ten files including strict replay fixtures. Updated two test clients for the current session metadata read.Validation: 119 adapter, runtime, and orchestrator replay tests pass; server typecheck, targeted lint and formatting pass. New CI pending. Independent Claude Opus 5 high review remains unavailable: direct launcher exited 1 due to expired OAuth before inference.
Targets V2 #2829. Updated with GPT-6 in Codex/T3.
Follow-up review: each descendant request retains a five-second deadline; removed the fixed whole-traversal cutoff so deep trees are fully attempted. New four-level/36-second simulated regression passes; all 27 adapter tests and server typecheck pass on this follow-up. Timeout errors are constructed at the request boundary.
Latest review follow-up: SDK error detail now derives only from operation/status; raw response stays in cause. 41 adapter/runtime tests plus server types/lint pass.